acc: run apps/inline_config locally#5647
Open
pietern wants to merge 1 commit into
Open
Conversation
The testserver's AppsGetDeployment fabricated a deployment with only an ID and status, so the inline config.command and config.env never echoed back locally. Return the stored ActiveDeployment instead, masking env var values to match the real GET response (name only, no value). Co-authored-by: Isaac
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: ff00e9e
24 interesting tests: 13 SKIP, 7 KNOWN, 4 flaky
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppsGetDeploymentnow returns the stored deployment (with env-var values masked) instead of an empty one, so the inlinecommand/env_varsround-trip works against the fake.This pull request and its description were written by Isaac.