acc: run three resource tests locally#5646
Open
pietern wants to merge 1 commit into
Open
Conversation
…rds/create locally These three acceptance tests were marked Local = false (cloud-only) but the in-process testserver already models everything they exercise: - volumes/recreate and jobs/shared-root-path pass against the fake unchanged; their behavior is fully modeled (UC volumes/grants/schemas, and a client-side shared-root-path warning respectively). - permissions/dashboards/create only diverged on the auto-added CAN_MANAGE ACL identity (service_principal_name on cloud vs user_name locally). Setting IsServicePrincipal = true makes the local deploy identity an SP so the golden matches. Each test keeps Cloud = true so it still runs in the nightly cloud suite. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 1eb73c6
22 interesting tests: 13 SKIP, 7 KNOWN, 2 flaky
Top 20 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flip
volumes/recreate,jobs/shared-root-path, andpermissions/dashboards/createtoLocal = true; the testserver already handles them.permissions/dashboards/createsetsIsServicePrincipal = trueso the CAN_MANAGE ACL matches the cloud golden.This pull request and its description were written by Isaac.