acc: read postgres top-level ID fields directly in direct engine#5642
Open
pietern wants to merge 1 commit into
Open
acc: read postgres top-level ID fields directly in direct engine#5642pietern wants to merge 1 commit into
pietern wants to merge 1 commit into
Conversation
The SDK bump to v0.147.0 (#5636) added top-level ID fields (project_id, branch_id, endpoint_id, database_id, role_id) to the postgres resource types, which the real Lakebase GET APIs now return. The direct engine make*Remote helpers previously dug the ID out of the status subobject; read the top-level field directly instead. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: a60eb90
21 interesting tests: 14 SKIP, 7 KNOWN
Top 21 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Read the top-level ID field directly in the postgres
make*Remotehelpers instead of digging it out ofstatus.Why
The SDK bump to v0.147.0 (#5636) added top-level ID fields that the Lakebase GET APIs now return, making the
statusindirection unnecessary. Example API docs: https://docs.databricks.com/api/workspace/postgres/getprojectThis pull request and its description were written by Isaac.