Render deployment_id and version_id in bundle summary#5638
Open
ilyakuz-db wants to merge 1 commit into
Open
Conversation
Co-authored-by: Isaac
Contributor
Approval status: pending
|
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: 6289a12
23 interesting tests: 14 SKIP, 7 KNOWN, 2 flaky
Top 28 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle summarynow surfaces the bundle's deployment metadata service identifiers —deployment_idand the currentversion_id— when the deployment metadata service is in use (managed state + direct engine). They appear as aDeployment:section in text output and as a top-leveldeploymentobject in--output json. Non-DMS summaries are unchanged.version_idisn't known to a read-only command, so summary fetches the latestlast_version_idfrom the deployment record viaGetDeployment.Why
The in-workspace DABs UI needs the bundle-level
deployment_id+version_idto link to the deployment metadata page. Until now these were only resolved internally (b.DeploymentID) or stamped per-resource for the jobs UI — no command exposed the bundle's own identifiers. This stacks on the DMS branch (#4856).Tests
Extended the
bundle/dms/plan-and-summaryacceptance test to cover both the textDeployment:block and thebundle summary -o jsondeploymentobject.