Add jobs/runs/submit handler to testserver#5634
Open
anton-107 wants to merge 1 commit into
Open
Conversation
The test server only handled jobs/create, run-now, and runs.get/get-output/list, so commands that call client.Jobs.Submit (the one-time run endpoint) could not be exercised in local acceptance tests. Add a JobsSubmit handler that records the submitted spec, returns a run ID, and stores a retrievable run. Submitted tasks are reported as RUNNING in both the V1 run state (so the `jobs submit` waiter is driven to TERMINATED by JobsGetRun) and the V2 per-task status, and are not executed locally. This lets acceptance tests assert the submitted environments spec (e.g. base_environment) via recorded requests. Includes unit tests for the handler and an acceptance test for `jobs submit`. Co-authored-by: Isaac
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: e9c8a87
24 interesting tests: 14 SKIP, 7 KNOWN, 3 flaky
Top 24 slowest tests (at least 2 minutes):
|
denik
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The test server only handled jobs/create, run-now, and runs.get/get-output/list, so commands that call client.Jobs.Submit (the one-time run endpoint) could not be exercised in local acceptance tests.
Add a JobsSubmit handler that records the submitted spec, returns a run ID, and stores a retrievable run. Submitted tasks are reported as RUNNING in both the V1 run state (so the
jobs submitwaiter is driven to TERMINATED by JobsGetRun) and the V2 per-task status, and are not executed locally. This lets acceptance tests assert the submitted environments spec (e.g. base_environment) via recorded requests.Why
Tests
Includes unit tests for the handler and an acceptance test for
jobs submit.