acceptance: don't apply Ignore filter to out* files#4762
Open
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Collaborator
|
Commit: 5dc612c
18 interesting tests: 9 SKIP, 7 KNOWN, 2 flaky
Top 23 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Mar 17, 2026
simonfaltum
approved these changes
Mar 18, 2026
denik
force-pushed
the
denik/ignore-output
branch
2 times, most recently
from
0618943 to
bd00434
Compare
denik
force-pushed
the
denik/ignore-output
branch
from
bd00434 to
c6fa6ef
Compare
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: low Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @andrewnester, @anton-107, @simonfaltum Suggestions based on git history of 23 changed files (20 scored). See CODEOWNERS for path-specific ownership rules. |
denik
requested review from
jefferycheng1,
kanterov and
lennartkats-db
as code owners
Inherited Ignore patterns (e.g. `databricks.yml` from bundle/test.toml) were silently swallowing output files in template tests, preventing them from being tracked and updated with -update. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…se time Rename test artifacts from out.json/out.app-run to tmp.json/tmp.app-run to comply with the new validation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- snapshot-comparison: rename out.bundle*.json to tmp.bundle*.json - postgres_endpoints/projects: set RecordRequests=false, remove out.requests.txt from Ignore - git_source: update output.txt to match renamed tmp.app-run Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
denik
force-pushed
the
denik/ignore-output
branch
from
3d47cd9 to
5dc612c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignorepatterns (e.g.databricks.ymlfrombundle/test.toml) were silently swallowing output files in template tests, preventing them from being detected as new/changed and updated with-update.Ignorefilter for paths starting with"out", matching the existing convention for output files.Test plan
go test ./acceptance -run TestAccept/bundle/templates/lakeflow-pipelines/python -update -vnow correctly detects and writesoutput/my_lakeflow_pipelines/databricks.yml🤖 Generated with Claude Code