Ignore self-referencing __settings__ in default profile resolution#4761
Merged
simonfaltum merged 3 commits intomainfrom Mar 18, 2026
Merged
Ignore self-referencing __settings__ in default profile resolution#4761simonfaltum merged 3 commits intomainfrom
__settings__ in default profile resolution#4761simonfaltum merged 3 commits intomainfrom
Conversation
Co-authored-by: Isaac
simonfaltum
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: ff07c4a
18 interesting tests: 9 SKIP, 7 KNOWN, 1 flaky, 1 RECOVERED
Top 31 slowest tests (at least 2 minutes):
|
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Mar 18, 2026
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 2c24bd3
39 interesting tests: 12 flaky, 12 RECOVERED, 11 KNOWN, 3 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The write path for default profile settings (
SetDefaultProfile,SaveToProfile) validates that__settings__cannot be used as a profile name. However, the read path (GetConfiguredDefaultProfileFrom) had no such guard. If a user manually edits their~/.databrickscfgto setdefault_profile = __settings__, the CLI would try to load the[__settings__]section as a profile, resulting in a confusing error (e.g. "no host configured") instead of silently ignoring the invalid value.This was identified while reviewing the same pattern in the Go SDK, where a similar gap existed in the config file loader's
Configuremethod.Changes
Before:
GetConfiguredDefaultProfileFromreturned whatever string was in[__settings__].default_profile, including__settings__itself.Now:
GetConfiguredDefaultProfileFromreturns""when the value equals the reserved__settings__section name. This causes the resolution to fall through to the next step (single-profile fallback, DEFAULT section, or empty), which is the correct behavior.Test plan
TestGetConfiguredDefaultProfile: verifies self-referencing value returns"".TestGetDefaultProfile: verifies self-referencing value falls through to single-profile fallback.go test ./libs/databrickscfg/...passes.This pull request was AI-assisted by Isaac.