Fix nil location in sequences in expanded globs #4465
Merged
+64
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakuz-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 83b37c7
19 interesting tests: 7 KNOWN, 5 SKIP, 4 RECOVERED, 3 flaky
Top 50 slowest tests (at least 2 minutes):
|
denik
approved these changes
Feb 9, 2026
| if "environment" not in r: | ||
| r["environment"] = {} | ||
| if "dependencies" not in r["environment"]: | ||
| r["environment"]["dependencies"] = [] |
Contributor
There was a problem hiding this comment.
nit: setdefault is handy for cases like this:
r.setdefault("environment", {}).setdefault("dependencies", []).append(...)
andrewnester
approved these changes
Feb 9, 2026
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding location to the sequence in expanded globs. Location is present for the list element, but not for the list itself. I.e.,
resources.pipelines.pipeline.environment.dependencies[0]has a location, butresources.pipelines.pipeline.environment.dependenciesdoes not. This PR fixes thatWhy
In config sync, we check whether the field location is nil to see if the value is a CLI default. In fields affected by
expand_globsmutator, every sequence item has its own location, but not the sequence itself. That causes config remote sync to work incorrectly - the field is considered as default, and added to the root of the resource, instead of patching the existing fieldTests