-
Notifications
You must be signed in to change notification settings - Fork 142
Bump SDK to v0.104.0. Bump TF to v1.105
#4457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Commit: eb272d3
199 interesting tests: 156 MISS, 22 FAIL, 7 KNOWN, 5 SKIP, 4 RECOVERED, 3 PANIC, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
| make schema | ||
|
|
||
| # Fetch version tags (required for make schema-for-docs). | ||
| git fetch origin 'refs/tags/v*:refs/tags/v*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make schema-for-docs was failing on arca because the version tags were not present locally. This fixes the script by fetching the version tags beforehand.
| Usage policy of this pipeline. | ||
| "x-databricks-preview": |- | ||
| PRIVATE | ||
| github.com/databricks/cli/bundle/config/resources.PostgresBranch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got removed by the generator. The JSON schema still has these descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. There's a couple of higher priority fixes I needed to get in so I did not look deeper. I can manually revert it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted these manually.
| Usage policy of this pipeline. | ||
| "x-databricks-preview": |- | ||
| PRIVATE | ||
| github.com/databricks/cli/bundle/config/resources.PostgresBranch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why though?
c1f77b1 to
b60b9f0
Compare
1.105
| "create_time": "[TIMESTAMP]", | ||
| "dashboard_id": "[DASHBOARD_ID]", | ||
| "display_name": "test dashboard", | ||
| "etag": [ETAG], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TF changes here likely stopped etags from being serialized in patch request. It was optional always and does not impact correctness for dashboards.
We never set etag in direct PATCH requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.105v0.104.0. Bump TF to v1.105
|
The integration tests are on UC environments due to access to WSFS timing out. Eyeballing the failed tests there don't seem to be genuine regressions but I might have missed something. Will keep an eye on nightlies. Merging for now. |
Other than the version bumps, this PR also:
jsonschema_for_docs.jsonby fetching tags.