-
Notifications
You must be signed in to change notification settings - Fork 141
Add --version flag to apps init for version pinning #4403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Commit: 4b3434a
21 interesting tests: 7 KNOWN, 5 SKIP, 5 RECOVERED, 4 flaky
Top 50 slowest tests (at least 2 minutes):
|
33ace28 to
1614cb3
Compare
MarioCadenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found 2 bugs while testing this and a suggestions
- the
--branchflag doesn't work as before, it works with some branches, but if the branch contains/which many people do things likefeat/somethingthen it breaks - if the gh cli is not installed, and I run
databricks apps initits fully broken and I need to provide the version. Version should be latest by default so it works even without a provided version - (suggestion) when passing the version, it needs to contain the exact tag like
--version v0.3.0, maybe we could also allow passing--version 0.3.0and check ourselves if thevis present or not and add it?
MarioCadenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approving with one small comment
I think this warning
Warning: gh CLI not found, using main branch. Install gh CLI or use --version to pin to a specific release.
should probably be a debug log or something to only show when the --version flag is provided? it might be confusing for users that are simply running databricks apps init
As they probably don't really care about the version used behind the scenes 😅 and this will create confusion
18ce5bc to
cc85ae8
Compare
|
Commit: 70c0de7
39 interesting tests: 23 flaky, 7 RECOVERED, 5 SKIP, 4 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
No description provided.