chore: fix result types in generated appKitTypes.d.ts#195
Closed
chore: fix result types in generated appKitTypes.d.ts#195
Conversation
When DATABRICKS_WAREHOUSE_ID is not set, `appkit generate-types` exits early without writing the file. This leaves templates with analytics queries missing appKitTypes.d.ts entirely, causing TS build errors. Add a fixAppKitTypes() post-processing step that either patches `result: unknown` in an existing file, or generates the file from scratch by scanning SQL files and using known result types. Co-authored-by: Isaac
pkosiec
force-pushed
the
pkosiec/fix-appkit-types-unknown
branch
from
bda650b to
f0886be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
result: unknownwhen no warehouse is available during template generation (generate-app-templates.ts)AnalyticsPage.tsxwhich usesdata.lengthanddata[0].valuefixAppKitTypes()postProcess step that replacesresult: unknownwith correct types for known template queries (hello_world,mocked_sales)This pull request was AI-assisted by Isaac.