Skip to content

ENH: allow copy= in from_dlpack #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ev-br wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ENH: allow copy= in from_dlpack #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions array_api_strict/_creation_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,15 +212,12 @@ def from_dlpack(
if copy is not _undef:
raise ValueError("The copy argument to from_dlpack requires at least version 2023.12 of the array API")

# Going to wait for upstream numpy support
if device is not _undef:
_check_device(device)
else:
device = None
if copy not in [_undef, None]:
raise NotImplementedError("The copy argument to from_dlpack is not yet implemented")

return Array._new(np.from_dlpack(x), device=device)
return Array._new(np.from_dlpack(x, copy=copy), device=device)


def full(
Expand Down
Loading