Open
Conversation
mdhaber
commented
Nov 23, 2025
tests/test_funcs.py
Outdated
| x[mask] = -np.inf | ||
| mask = rng.random(shape) > 0.9 | ||
| x[mask] = np.inf | ||
| x = np.sort(x, stable=True, axis=-1) |
Contributor
Author
There was a problem hiding this comment.
This is unnecessary and causing CI failures.
Suggested change
| x = np.sort(x, stable=True, axis=-1) | |
| x = np.sort(x, axis=-1) |
Contributor
Author
|
Re: I don't really want to deal with typing or GHA lint complaints in I don't know what to do about GHA's lint complaints in |
Member
How are you seeing these failures? Via |
Contributor
Author
|
Yup |
Member
|
bizarre! |
Contributor
Author
|
maybe it's all because Details |
Member
|
seems to be the problem yes, I fear it might be something windows-specific. |
Contributor
Author
|
K, well I got on my mac, fixed most of the complaints, and silenced the rest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses scipy/scipy#23930 (comment)
Thoughts:
searchsortedfor all 1D tests. It would be good to have some way of running the 1D test cases with the genericsearchsortedcode, though. The important part is the length of the arrays along the last axis, so the simplest way would be to just define 2D cases with the same lengths along the second axis.torchdelegates multidimensional cases totorch.searchsorted, too, but it behaves differently than other backends in some cases involving NaNs. It doesn't surprise me because the standard doesn't define sorting w/ NaNs and torch doesn't always do the typical thing. Not sure how deeply we want to go into that.broadcast_shapesto help with that, but I would prefer not to work on that. I could add a check for this condition and raise a consistent error, if that would be sufficient.sideis one of the allowed values?