Skip to content

TST: skip dlpack tests on numpy 1.2x, dask, and cupy #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ev-br merged 1 commit into from
Apr 3, 2026
Merged

TST: skip dlpack tests on numpy 1.2x, dask, and cupy #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cupy-xfails.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,8 @@ array_api_tests/test_special_cases.py::test_binary[nextafter(x1_i is +0 and x2_i

# cupy 13.x follows numpy 1.x w/o weak promotion: result_type(int32, uint8, 1) != result_type(int32, uint8)
array_api_tests/test_data_type_functions.py::TestResultType::test_with_scalars

# CuPy 14 does not support copy= dlpack argument
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment # CuPy 14 does not support copy= dlpack argument is a bit unclear/grammatically off. Please clarify it to explicitly reference the DLPack protocol/__dlpack__ keyword argument (e.g., that CuPy’s __dlpack__/from_dlpack does not accept the copy= keyword expected by the Array API tests).

Suggested change
# CuPy 14 does not support copy= dlpack argument
# CuPy 14's DLPack support (__dlpack__/from_dlpack) does not accept
# the copy= keyword argument expected by the Array API tests.

Copilot uses AI. Check for mistakes.
array_api_tests/test_dlpack.py::test_dunder_dlpack
array_api_tests/test_dlpack.py::test_from_dlpack

5 changes: 5 additions & 0 deletions dask-xfails.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,3 +173,8 @@ array_api_tests/test_special_cases.py::test_unary[sqrt(real(x_i) is +infinity an
array_api_tests/test_special_cases.py::test_unary[tanh(real(x_i) is +infinity and isfinite(imag(x_i)) and imag(x_i) > 0) -> 1 + 0j]
array_api_tests/test_special_cases.py::test_unary[expm1((real(x_i) is +0 or real(x_i) == -0) and imag(x_i) is +0) -> 0 + 0j]
array_api_tests/test_special_cases.py::test_unary[acosh(real(x_i) is +0 and imag(x_i) is NaN) -> NaN \xb1 \u03c0j/2]

# no dlpack support
array_api_tests/test_dlpack.py::test_dlpack_device
array_api_tests/test_dlpack.py::test_dunder_dlpack
array_api_tests/test_dlpack.py::test_from_dlpack
5 changes: 5 additions & 0 deletions numpy-1-22-xfails.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,3 +191,8 @@ array_api_tests/test_special_cases.py::test_unary[expm1((real(x_i) is +0 or real
array_api_tests/test_special_cases.py::test_unary[sqrt(real(x_i) is +infinity and isfinite(imag(x_i)) and imag(x_i) > 0) -> +0 + infinity j]
array_api_tests/test_special_cases.py::test_unary[acosh(real(x_i) is +0 and imag(x_i) is NaN) -> NaN \xb1 \u03c0j/2]
array_api_tests/test_special_cases.py::test_unary[tanh(real(x_i) is +infinity and isfinite(imag(x_i)) and imag(x_i) > 0) -> 1 + 0j]

# no dlpack support
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as numpy-1-26-xfails.txt: # no dlpack support is too broad here, since from_dlpack exists in NumPy 1.22+ (and this file already has from_dlpack/__dlpack__ signature xfails). Please reword the comment to capture the specific missing/non-compliant pieces that cause these tests to be skipped.

Suggested change
# no dlpack support
# NumPy 1.22 has from_dlpack/__dlpack__, but device handling and full DLPack protocol compliance are still missing/non-compliant

Copilot uses AI. Check for mistakes.
array_api_tests/test_dlpack.py::test_dlpack_device
array_api_tests/test_dlpack.py::test_dunder_dlpack
array_api_tests/test_dlpack.py::test_from_dlpack
5 changes: 4 additions & 1 deletion numpy-1-26-xfails.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ array_api_tests/test_special_cases.py::test_unary[sqrt(real(x_i) is +infinity an
array_api_tests/test_special_cases.py::test_unary[acosh(real(x_i) is +0 and imag(x_i) is NaN) -> NaN \xb1 \u03c0j/2]
array_api_tests/test_special_cases.py::test_unary[tanh(real(x_i) is +infinity and isfinite(imag(x_i)) and imag(x_i) > 0) -> 1 + 0j]


# no dlpack support
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note # no dlpack support is misleading in this file: from_dlpack is imported from NumPy (and is already referenced in the earlier # 2023.12 support signature xfails). Consider rewording this comment to describe the actual incompatibility being skipped here (e.g., missing __dlpack__/__dlpack_device__ on ndarray, or from_dlpack signature/behavior not matching the Array API tests), so future maintainers know what to re-check when NumPy gains compliant support.

Suggested change
# no dlpack support
# DLPack-related Array API tests are still incompatible: ndarray lacks
# __dlpack__/__dlpack_device__, and NumPy's from_dlpack support does not
# yet match these test expectations.

Copilot uses AI. Check for mistakes.
array_api_tests/test_dlpack.py::test_dlpack_device
array_api_tests/test_dlpack.py::test_dunder_dlpack
array_api_tests/test_dlpack.py::test_from_dlpack
Comment on lines +88 to +91
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This DLPack-related xfail block is far away from the existing # 2023.12 support section that already contains the from_dlpack / __dlpack__ signature xfails. To keep the file organized, please move this block next to the other DLPack entries (or add a dedicated DLPack section) so all related xfails are co-located.

Copilot uses AI. Check for mistakes.


Loading