Skip to content

Fix #14564 FP AssignmentIntegerToAddress (MAKEINTRESOURCE() in windows.cfg) #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −3
Open

Fix #14564 FP AssignmentIntegerToAddress (MAKEINTRESOURCE() in windows.cfg) #8295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7fad40
Update windows.cfg
chrchr-github Mar 4, 2026
17d016c
Update windows.cpp
chrchr-github Mar 4, 2026
d7a68b4
Update windows.cpp
chrchr-github Mar 4, 2026
eb1a94c
Update windows.cpp
chrchr-github Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cfg/windows.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13345,9 +13345,9 @@ HFONT CreateFont(
<define name="MiniDumpWithAvxXStateContext" value="0x0200000"/>
<define name="MiniDumpWithIptTrace" value="0x0400000"/>
<define name="MiniDumpValidTypeFlags" value="0x0800000"/>
<define name="MAKEINTRESOURCEA(i)" value="i"/>
<define name="MAKEINTRESOURCEW(i)" value="i"/>
<define name="MAKEINTRESOURCE(i)" value="i"/>
<define name="MAKEINTRESOURCEA(i)" value="((LPSTR)((ULONG_PTR)((WORD)(i))))"/>
<define name="MAKEINTRESOURCEW(i)" value="((LPWSTR)((ULONG_PTR)((WORD)(i))))"/>
<define name="MAKEINTRESOURCE(i)" value="((LPTSTR)((ULONG_PTR)((WORD)(i))))"/>
Copy link
Owner

@danmar danmar Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious. why are there 3 casts?

Copy link
Collaborator Author

@chrchr-github chrchr-github Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but this is the original definition. Maybe to avoid warnings like -Wint-to-void-pointer-cast, since WORD is only 16 bits.

<define name="FILE_ATTRIBUTE_ARCHIVE" value="0x20"/>
<define name="FILE_ATTRIBUTE_COMPRESSED" value="0x800"/>
<define name="FILE_ATTRIBUTE_DEVICE" value="0x40"/>
Expand Down
4 changes: 4 additions & 0 deletions test/cfg/windows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ std::string constVariable_GetModuleFileName(void) {
return std::string{path};
}

const TCHAR* constVariable_MAKEINTRESOURCE() { // #14564
return MAKEINTRESOURCE(5 - 1);
}

int stringCompare_mbscmp(const unsigned char *string1, const unsigned char *string2)
{
// cppcheck-suppress stringCompare
Expand Down
Loading