Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Not a thorough review but just some things which accumulated over time. |
|
| << " " << ATTR_CALL_ARGVALUETYPE << "=\"" << static_cast<unsigned>(callValueType) << "\"" | ||
| << " " << ATTR_CALL_ARGVALUE << "=\"" << callArgValue.value << "\"" | ||
| << " " << ATTR_CALL_UNKNOWN_FUNCTION_RETURN << "=\"" << static_cast<int>(callArgValue.unknownFunctionReturn) << "\""; | ||
| << " " << ATTR_CALL_UNKNOWN_FUNCTION_RETURN << "=\"" << static_cast<unsigned>(callArgValue.unknownFunctionReturn) << "\""; |
There was a problem hiding this comment.
Why is it important to use unsigned instead of int.
I am not against this and would likely accept such unsigned use if this was new code. But if you refactor you need to have some important reasons. We could get a commit battle where somebody else thinks that it should be plain int and send me a PR about that. I see no clear reasons to use neither int nor unsigned here.
Using unsigned just because the value is always positive is not a good reason in my opinion. That is dangerous approach and leads to conversion problems.
3 participants
No description provided.