feat: double freeform post content length to 20000#6282
Merged
Conversation
Raise BODY_MAX_LENGTH from 10,000 to 20,000 characters so the composer's maxInputLength (and its remaining-characters counter) stays in sync with the daily-api limit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doubles the freeform post composer body limit from 10,000 to 20,000 characters.
Changes
BODY_MAX_LENGTHfrom10_000to20_000inpackages/shared/src/components/post/composer/TextForm.tsx. This value is passed asmaxInputLengthto the rich text editor, so both the hard input cap and the "characters remaining" counter update automatically.Key decisions
MAX_CONTENT_LENGTHin daily-api, changed in a parallel PR) to preserve the client/server invariant — a client-only bump would let users write text the API rejects.BODY_MAX_LENGTHdrivesmaxInputLength(and its counter) directly, and the shared testing philosophy keeps the correctness guarantee at the API boundary. Verified via strict typecheck, ESLint, and the existingSmartComposerModalspec that renders the composer.Closes ENG-1823
Created by Huginn 🐦⬛
Preview domain
https://eng-1823-double-the-post-content.preview.app.daily.dev