feat(giveback): add FAQ tab, redesign sponsors (unrendered for launch)#6252
Merged
Conversation
Adds the FAQ tab (renders the existing GivebackFaq, now headed by the shared GivebackTabHeading with refreshed copy). Tabs are now Take action / Impact / Causes / FAQ. Redesigns GivebackSponsorTiers into self-describing sponsor cards (logo tile + colored tier pill, monochrome at rest with color on hover, fixed per-tier logo heights, name fallback) and gates the whole sponsor wall behind the new featureGivebackSponsors flag, defaulted off for launch. Rendered GivebackFaq directly for the FAQ tab instead of adding a do-nothing GivebackFaqPanel wrapper.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sponsors aren't launching with the campaign, so just don't render them rather than carry a feature flag. Removes the sponsor section from the page and the featureGivebackSponsors flag. GivebackSponsorTiers (with its redesign) and its spec stay in the codebase, ready to re-enable with one line when sponsors go live.
idoshamun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fourth step of the giveback design pass from #6247 (PR 4/6). Adds the FAQ tab and removes the Sponsors section from the page.
FAQ tab
faqtab renders the existingGivebackFaq, now headed by the sharedGivebackTabHeadingwith refreshed answer copy.Sponsors
GivebackSponsorTiersis redesigned (self-describing cards: logo tile + tier pill, monochrome-at-rest → color-on-hover, fixed per-tier logo heights, name fallback) and kept in the codebase with its spec, just not wired into the page. Re-enable with one line when sponsors go live.Scope notes
GivebackFaqdirectly for the FAQ tab rather than adding aGivebackFaqPanelwrapper whose only body would be<GivebackFaq />.GivebackSection.titlewas already optional onmain, so the FAQ's switch toGivebackTabHeadingneeded no shell change.Verification
tsc: no new errors (27 pre-existing, unrelated)