UI/UX: Missing aria-label on icon-only back button in AuthHeader#6246
Open
kumburovicbranko682-boop wants to merge 1 commit into
Conversation
…eader The back button renders only an ArrowIcon with no visible text. No aria-label or aria-labelledby is provided, so screen readers will announce it generically as "button" with no indication of its purpose. For icon-only buttons, an accessible name is required by WCAG 4.1.2. Affected files: AuthHeader.tsx Signed-off-by: kumburovicbranko682-boop <295886834+kumburovicbranko682-boop@users.noreply.github.com>
|
@kumburovicbranko682-boop is attempting to deploy a commit to the Daily Dev Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎨 UI/UX Improvement
Problem
The back button renders only an ArrowIcon with no visible text. No aria-label or aria-labelledby is provided, so screen readers will announce it generically as "button" with no indication of its purpose. For icon-only buttons, an accessible name is required by WCAG 4.1.2.
Severity:
mediumFile:
packages/shared/src/components/auth/AuthHeader.tsxSolution
<Button
icon={}
variant={ButtonVariant.Tertiary}
className="mr-2"
onClick={onBack}
aria-label="Go back"
/>
Changes
packages/shared/src/components/auth/AuthHeader.tsx(modified)Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #6245