Skip to content

Update visuals for sweep#5865

Draft
AmarTrebinjac wants to merge 16 commits intodavidercruz/swipe-onboarding-wipfrom
update-visuals-for-sweep
Draft

Update visuals for sweep#5865
AmarTrebinjac wants to merge 16 commits intodavidercruz/swipe-onboarding-wipfrom
update-visuals-for-sweep

Conversation

@AmarTrebinjac
Copy link
Copy Markdown
Contributor

@AmarTrebinjac AmarTrebinjac commented Apr 15, 2026

Changes

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://update-visuals-for-sweep.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Apr 29, 2026 10:32am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Apr 29, 2026 10:32am

Request Review

@AmarTrebinjac
Copy link
Copy Markdown
Contributor Author

@claude please fix the build issues

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 28, 2026

Claude finished @AmarTrebinjac's task in 2s —— View job


Fixed Build Issues

  • Check CI status and identify build errors
  • Analyze changed files — swipeOnboardingGuidance.spec.ts had 9 failing tests
  • Fix failing tests in swipeOnboardingGuidance.spec.ts
  • Commit and push fixes

Root cause: The implementation constants were updated to lower milestone values (MIN_TO_UNLOCK: 10→5, IMPROVE_MILESTONE: 20→10, REFINE_TARGET: 40→20) but the spec was still asserting the old thresholds and copy (e.g. "Swipe 10 posts to get started." instead of "Start swiping", n=10 → 25% bar progress instead of 50%).

Fix: Updated all 13 test assertions in swipeOnboardingGuidance.spec.ts to match current behavior. All 19 swipe onboarding tests now pass.

…tants

Tests were written for the old thresholds (10/20/40) but the implementation
was updated to lower values (MIN_TO_UNLOCK=5, IMPROVE_MILESTONE=10,
REFINE_TARGET=20). Update all spec assertions to match current behavior.

Co-authored-by: Amar Trebinjac <AmarTrebinjac@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants