[!] add OpenTelemetry tracing and metrics support#768
Open
pashagolub wants to merge 4 commits into
Open
Conversation
- Add `OTelOpts` config struct - Add `internal/otel` package: Provider, Tracer, Meter, Shutdown, Noop - Add 5 metric instruments - Instrument `executeChain` and `executeTask` with spans and metrics - Wire real provider in `main.go` with graceful shutdown - `ValidateOTel()` validates endpoint scheme, ratio, and timeouts - Protocol auto-detected from URL scheme (grpc:// vs http(s)://) - Headers are YAML-only (prevents secrets in shell history) - Fallback to `Noop` provider on init failure
Coverage Report for CI Build 27361355738Coverage decreased (-0.6%) to 89.778%Details
Uncovered Changes
Coverage Regressions9 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
0xgouda
reviewed
Jun 11, 2026
Contributor
There was a problem hiding this comment.
I am testing this and noticed that there are no INFO log messages for metrics/traces collection or upload, which in my opinion is nice to have to be able to confirm that things are working as expected and maybe help in deubgging in some scenarios.
0xgouda
reviewed
Jun 11, 2026
0xgouda
left a comment
Contributor
There was a problem hiding this comment.
Thinking Out Loud: How can one configure 2 different endpoints, one for trace exportation and one for metrics?
Collaborator
Author
What? In what way log messages are connected to metrics and traces? What am I missing here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTelOptsconfig structinternal/otelpackage: Provider, Tracer, Meter, Shutdown, NoopexecuteChainandexecuteTaskwith spans and metricsmain.gowith graceful shutdownValidateOTel()validates endpoint scheme, ratio, and timeoutsNoopprovider on init failure