[codegen] extract interface access methods from member.ts#756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
member.tswas 3311 lines — the second largest file in the codebase.After
No user-facing change. Internal refactor only. Interface access logic now lives in
src/codegen/expressions/access/interface-access.ts(539 lines), reducingmember.tsto 2865 lines.Description
Extracts 3 methods from MemberAccessGenerator into free functions:
handleChainedInterfaceAccess(~315 lines) — resolves chained property access on interface-typed valuesaccessInterfacePropertyWithNamedStruct(~69 lines) — loads field from a named interface structaccessObjectPropertyWithNamedInterface(~86 lines) — loads field from an i8* with known interface typeAll functions use the existing
MemberAccessGeneratorContextinterface. No chained method calls — native compiler compatible.Part of #727.