Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
getFieldLlvmTypein calls.ts andmethodReturnTypeToLlvmin class.ts had silentreturn "i8*"fallbacks that would mask unrecognized types instead of failing loud.After
Both functions now have explicit type dispatch for known categories (primitives, LLVM types, inline objects, function types, class/interface names) before any fallback.
methodReturnTypeToLlvmthrows on truly unrecognized types.getFieldLlvmTypepreserves LLVM type passthroughs before the final catch-all.Description
Part of #710 (eliminate silent-default dispatch). Third PR in series after #749 (fieldTypeToLlvmPrimitive dedup) and #750 (fieldTypeToLlvm dedup + fail-loud). Behavioral equivalence maintained — no test changes needed, all 880 tests pass.
Next Steps
Continue through remaining silent-default sites identified in #710.