Conversation
Collaborator
Author
|
Symfony gains are also good, but strongly depend on the route. Something like the homepage (no session, no nothing, just a ton of file accesses) sees rather small gains, while others see decent gains. Training data was on all routes of the project, but benchmark only on few. @nicolas-grekas The smaller the route surface of the project and the more time it spends in php, the more likely we are to see higher gains. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds profile guided optimizations to the project
not so nice:
also adds required pre-work for: php/frankenphp#2361
SPC_CMD_VAR_FRANKENPHP_XCADDY_MODULES=... ${FRANKENPHP_SOURCE_DIR}and rewrite the env var to be set before the second GlobalEnvManager pass)Little preview of frankenphp benchmarks:
Little preview of php-cli benchmarks: