Skip to content

Fix sqlsrv redundant cflags when building PHP#1078

Open
crazywhalecc wants to merge 6 commits intomainfrom
fix/sqlsrv
Open

Fix sqlsrv redundant cflags when building PHP#1078
crazywhalecc wants to merge 6 commits intomainfrom
fix/sqlsrv

Conversation

@crazywhalecc
Copy link
Copy Markdown
Owner

What does this PR do?

Fix sqlsrv redundant cflags when building PHP. Resolve https://github.com/static-php/static-php-cli-hosted/actions/runs/23831532972/job/69465987785#step:13:17283 .

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@crazywhalecc crazywhalecc added bug Something isn't working os/windows Things only for Windows labels Apr 2, 2026
Anyway we don't support zstd windows build before
Anyway we don't support zstd windows build before
@henderkes
Copy link
Copy Markdown
Collaborator

Is this necessary? Redundant means it builds with extra flags that aren't necessary, but we shouldn't patch the build unless it actually leads to failure.

@crazywhalecc
Copy link
Copy Markdown
Owner Author

crazywhalecc commented Apr 3, 2026

Three things:

  • This build error seems due to sqlsrv treating the warning as error.
  • We haven't supported zstd on windows yet (v2).
  • ngtcp2 on Windows needs patched version of gnutls to enable QUIC feature, we haven't supported gnutls and its deps yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working os/windows Things only for Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants