Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Feb 10, 2026

Problem

No matter what the test matrix slot designates, CI/GHA will (currently) always use Python 3.12, which seems to be the default Python on the selected runner image. Example: Python 3.11 test matrix slot selects Python 3.12.

Outcome

CI: Re-add missing actions/setup-python recipe (solution)
CI: Fix HTTP certificate error when requesting example.org from GHA (side-effect)

Unrelated

CI: Trim release workflow. It will be fine using the default Python.
CI: Validate release workflow. Only push to PyPI on designated event.

@amotl amotl changed the title Ci restore python CI: Re-add missing actions/setup-python recipe Feb 10, 2026
@amotl amotl marked this pull request as ready for review February 10, 2026 20:41
@amotl amotl changed the base branch from rust-next to main February 10, 2026 20:42
@amotl amotl force-pushed the ci-restore-python branch from 6d30e52 to 9fc1a08 Compare February 10, 2026 20:42
@amotl amotl marked this pull request as draft February 10, 2026 21:03
@amotl amotl force-pushed the ci-restore-python branch 5 times, most recently from f544dea to eeb0a56 Compare February 10, 2026 21:36
@amotl amotl marked this pull request as ready for review February 10, 2026 21:52
Copy link
Member

@mfussenegger mfussenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup-uv action needs to be configured with the desired python version. See https://github.com/astral-sh/setup-uv?tab=readme-ov-file#python-version

Using both uv and actions/setup-python imho doesn't make much sense. Should be either/or

When connecting to non-CrateDB servers, the HttpClient will raise a ConnectionError like this:

>>> http_client = HttpClient(["https://example.org/"])
>>> http_client = HttpClient(["https://httpbin.org/html"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this? example.org is specifically for use in documentation examples.

Copy link
Member Author

@amotl amotl Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eeb0a56 was needed because CI/GHA started failing on macOS when using more recent versions than Python 3.12. I also don't like the change: Maybe you have an idea how to solve it differently?

HTTPSConnectionPool(host='www.example.org', port=443): Max retries exceeded
[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1081)

-- CI run #21882822361

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like example.org or GitHub runners fixed their certificates or certificate bundles, so this update was removed again.

Comment on lines 56 to 60
- name: Set up uv
uses: astral-sh/setup-uv@v7
with:
cache-dependency-glob: |
pyproject.toml
python-version: ${{ matrix.python-version }}
cache-suffix: ${{ matrix.python-version }}
Copy link
Member Author

@amotl amotl Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfussenegger: 3a70d51 now configures the astral-sh/setup-uv properly, and removes the actions/setup-python recipe again. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.10 slot now actually uses Python 3.10. 👍

@amotl amotl requested a review from mfussenegger February 11, 2026 13:43
@amotl amotl changed the title CI: Re-add missing actions/setup-python recipe CI: Configure astral-sh/setup-uv to use the right Python version Feb 11, 2026
@amotl amotl force-pushed the ci-restore-python branch from 0f21a92 to 0379dc7 Compare February 11, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants