Remove phpdbg from coverage targets#39
Draft
ohmyfelix wants to merge 1 commit intocontributte:masterfrom
Draft
Conversation
Use the PHP CLI for coverage targets to match the org-wide phpdbg removal tracked in contributte/contributte#73.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
phpdbgwithphpin the Makefile coverage targets so this repository follows the org-wide coverage runner migration tracked in contributte/contributte#73.Motivation
phpdbgis being removed from Contributte coverage targets. This keeps the local Makefile aligned with that migration.Changes
coverage-cloverto-p phpcoverage-htmlto-p phpTesting
Makefilecoverage targetsmake coverage-clovercurrently fails because this environment has no Xdebug/PCOV extension and is not running under PHPDBG)make testscurrently fails on PHP 8.5 becauseReflectionProperty::setAccessible()is deprecated intests/Cases/NetteDatabaseDataSourceTest.phpt)