Skip to content

fix(core): retry failed migrations#12990

Open
ShiroKSH wants to merge 1 commit into
continuedev:mainfrom
ShiroKSH:fix/retry-failed-migrations
Open

fix(core): retry failed migrations#12990
ShiroKSH wants to merge 1 commit into
continuedev:mainfrom
ShiroKSH:fix/retry-failed-migrations

Conversation

@ShiroKSH

Copy link
Copy Markdown

Summary

  • Retry a migration after its callback fails instead of leaving it permanently marked complete.
  • Claim the marker atomically, so concurrent callers do not run the same migration twice.
  • Cover retry, completed-marker, and concurrent-call behavior with focused tests.

Root cause

The migration marker was written before the callback ran. A rejected callback left the marker in place, so later startups skipped an incomplete migration.

Checks

  • npm run vitest -- util/paths.vitest.ts
  • npm exec --yes --package=typescript@5.6.3 -- tsc -p ./ --noEmit
  • npx --prefix core eslint core/util/paths.ts core/util/paths.vitest.ts
  • npx prettier --check util/paths.ts util/paths.vitest.ts

@ShiroKSH
ShiroKSH requested a review from a team as a code owner July 15, 2026 10:48
@ShiroKSH
ShiroKSH requested review from sestinj and removed request for a team July 15, 2026 10:48
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ShiroKSH

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant