Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions core/llm/llms/OpenAI.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
import { ChatMessage, CompletionOptions } from "../../index.js";
import OpenAI from "./OpenAI";

class TestOpenAI extends OpenAI {
convertArgsResponses(options: CompletionOptions, messages: ChatMessage[]) {
return this._convertArgsResponses(options, messages);
}
}

describe("OpenAI", () => {
test("omits temperature from Responses API requests unless configured", () => {
const openai = new TestOpenAI({ model: "gpt-5" });
const messages: ChatMessage[] = [{ role: "user", content: "Hello" }];
const baseOptions = { model: "gpt-5" } as CompletionOptions;

expect(
openai.convertArgsResponses(baseOptions, messages),
).not.toHaveProperty("temperature");
expect(
openai.convertArgsResponses({ ...baseOptions, temperature: 0 }, messages),
).toHaveProperty("temperature", 0);
});

test("should identify correct o-series models", () => {
const openai = new OpenAI({
model: "o3-mini",
Expand Down
4 changes: 3 additions & 1 deletion core/llm/llms/OpenAI.ts
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,9 @@ class OpenAI extends BaseLLM {
const body: ResponseCreateParamsBase = {
model,
input,
temperature: options.temperature ?? null,
...(options.temperature !== undefined && {
temperature: options.temperature,
}),
top_p: options.topP ?? null,
reasoning: {
effort: "medium",
Expand Down
Loading