Skip to content

Comments

chore: upgrade eslint to 9.39.2#10133

Closed
RomneyDa wants to merge 2 commits intomainfrom
dallin/eslint-upgrade
Closed

chore: upgrade eslint to 9.39.2#10133
RomneyDa wants to merge 2 commits intomainfrom
dallin/eslint-upgrade

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Feb 2, 2026

Description

  • Bump eslint to ^9, change configs to js
  • Fixes failing security scans

Continue Tasks: ▶️ 1 queued — View all


Summary by cubic

Upgraded ESLint to v9 and migrated all packages to the flat config format with a shared rules module for consistent linting. Simplifies lint scripts and keeps package-specific overrides intact across core, GUI, and VSCode.

  • Refactors

    • Replaced .eslintrc*.json with eslint.config.js in core, GUI, and VSCode, using sharedRules/sharedIgnores from eslint.shared.js.
    • Simplified scripts to "eslint ." and "eslint . --fix".
    • Preserved local overrides: core complexity/size limits and stricter no-floating-promises, VSCode keeps no-misused-promises as warn, GUI keeps React and no-barrel-files plugins with browser globals.
  • Migration

    • Requires Node 18.18+.
    • Run npm install to pick up ESLint 9 and plugin updates.
    • Use npm run lint / npm run lint:fix; no --ext flag needed.

Written for commit 4d8878a. Summary will update on new commits.

@RomneyDa RomneyDa requested a review from a team as a code owner February 2, 2026 19:03
@RomneyDa RomneyDa requested review from sestinj and removed request for a team February 2, 2026 19:03
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 2, 2026
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

✅ Review Complete

Code Review Summary

⚠️ Continue API authentication failed. Please check your CONTINUE_API_KEY.


@RomneyDa RomneyDa changed the title chore: eslint upgrade chore: upgrade eslint to 9.39.2 Feb 2, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 18 files

@RomneyDa
Copy link
Collaborator Author

various issues, closing, will be reattempted

@RomneyDa RomneyDa closed this Feb 20, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Feb 20, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant