Skip to content

Feature/cmg 774#1001

Open
AishDani wants to merge 7 commits intodevfrom
feature/cmg-774
Open

Feature/cmg 774#1001
AishDani wants to merge 7 commits intodevfrom
feature/cmg-774

Conversation

@AishDani
Copy link
Contributor

No description provided.

@AishDani AishDani requested a review from a team as a code owner March 16, 2026 12:05
@umeshmore45 umeshmore45 requested a review from Copilot March 16, 2026 12:07
@AishDani AishDani requested review from umeshmore45 and vikrantraut and removed request for Copilot March 16, 2026 12:07
@AishDani AishDani requested a review from vikrantraut March 18, 2026 08:25
vikrantraut
vikrantraut previously approved these changes Mar 18, 2026
@umeshmore45 umeshmore45 requested a review from Copilot March 20, 2026 06:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors parts of the Drupal migration pipeline to rely more on UI-provided content type/field mappings, adds typed config interfaces for Drupal services, and adjusts the migration step sequence (notably removing schema generation calls).

Changes:

  • Update Drupal migration flow in migration.service.ts (removed generateContentTypeSchemas step; updated createEntry invocation/signature usage).
  • Refactor Drupal entries processing to use contentTypes + fieldMapping passed in (instead of reading LowDB models inside the entries service).
  • Add Drupal config interfaces and tighten types in drupal.service.ts; harden Drupal assets/field-analysis services with additional defensive checks/sanitization.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
api/src/services/migration.service.ts Updates the Drupal migration orchestration (step sequence + updated createEntry args).
api/src/services/drupal/interface.ts Introduces DbConfig and AssetsConfig types for Drupal services.
api/src/services/drupal/field-analysis.service.ts Adds more defensive optional chaining around key-safety and parsing paths.
api/src/services/drupal/entries.service.ts Refactors entry transformation to use passed-in content type mappings; adjusts locale/content-type folder naming.
api/src/services/drupal/assets.service.ts Adds fid/filename sanitization, more defensive checks, and logging improvements in asset export.
api/src/services/drupal.service.ts Removes generateContentTypeSchemas export and introduces typed config usage for Drupal service methods.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants