Open
Conversation
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.chdir(tmpPath)before running the nestedcm:stacks:importsoprocess.cwd()stays the directory where the user invoked the CLI.contentstack-seedfailures ininteractive.test.ts(Inquirer default export mock) andgithub/client.test.ts(tar.extractmock typing).Motivation
While
chdirwas intended to keep import backups under the temp extract directory, it had two downsides:getLogPath(), which falls back tocwd/logs. Afterchdir, that pointed at the OS temp tree instead of the usual CLI working directory (for examplecli/packages/contentstack/logs)._backup_*folders underprocess.cwd(). Withchdir, those appeared under temp; temp cleanup is not guaranteed, so isolation did not buy much.Nested import already receives an absolute
-dpath; changing directory is not required to locate stack content.Behavior changes
…/tmp-…/logs/…cwd/logs/…(same as a normalcm:stacks:importfrom that directory)path.join(cwd, '_backup_<random>')— same as standalone import from that cwdTest changes
test/seed/interactive.test.ts: Mockinquirerwith{ __esModule: true, default: mockInquirer }soimport inquirer from 'inquirer'in production code resolves at runtime.test/seed/github/client.test.ts: Use(tar.extract as unknown as jest.Mock)when assigning the mock to satisfy TypeScript (TS2352).test/seed/importer.test.ts: Assertions that expectedchdirwere removed whenchdirwas dropped fromimporter.ts.How to verify
Run
cm:stacks:seedfromcli/packages/contentstack(or your usual cwd) and confirm logs appear under./logsand any_backup_*folders appear under that cwd if import creates a backup.