fix: preload pg_textsearch in shared_preload_libraries#5
Open
pyramation wants to merge 4 commits intomainfrom
Open
fix: preload pg_textsearch in shared_preload_libraries#5pyramation wants to merge 4 commits intomainfrom
pyramation wants to merge 4 commits intomainfrom
Conversation
- Add pg_textsearch and pgsodium to shared_preload_libraries in postgresql.conf.sample - Create root superuser role via initdb script (fixes CI health check failures) - Push to Docker Hub (constructiveio/postgres) in addition to GHCR - Requires DOCKERHUB_USERNAME and DOCKERHUB_TOKEN repo secrets
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
bot
changed the title
devin-ai-integration
bot
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
devin-ai-integration
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Appends
pg_textsearchtoshared_preload_librariesinpostgresql.conf.sampleso thatCREATE EXTENSION pg_textsearchworks without requiring manual postgres configuration. This fixes thepg_textsearch library not loadederrors inconstructive-dbCI.One-line change — the extension was already compiled and installed by the multi-stage build, but never preloaded at startup.
pgsodiumis intentionally not included inshared_preload_librariesbecause it requires apgsodium_getkeyscript at boot, which causes the container to crash on startup if absent.Review & Testing Checklist for Human
postgres:17-alpineimage doesn't already setshared_preload_librariesinpostgresql.conf.sample. The append (>>) means a second directive would take effect (last value wins in postgres config), but it's worth confirming there's no unintended override.constructive-dbCI to confirm thepg_textsearch library not loadederror is resolved.pgsodiumfrom preload doesn't break any downstream consumers that depend onCREATE EXTENSION pgsodium(they would need to configureshared_preload_librariesthemselves or the image needs apgsodium_getkeyscript added separately).Notes