Skip to content

fix: upgrade pg_textsearch to include ResourceOwnerEnlarge crash fix#3

Merged
pyramation merged 1 commit intomainfrom
devin/1772651870-upgrade-pg-textsearch
Mar 4, 2026
Merged

fix: upgrade pg_textsearch to include ResourceOwnerEnlarge crash fix#3
pyramation merged 1 commit intomainfrom
devin/1772651870-upgrade-pg-textsearch

Conversation

@pyramation
Copy link
Contributor

Summary

Upgrades pg_textsearch from v0.2.0 to main@ae1c221 to include the fix for issue #247 / PR #248 — a crash where BM25 index scans inside rolled-back transactions trigger ResourceOwnerEnlarge called after release started, killing the PostgreSQL server.

The fix is not included in any tagged release yet (latest is v0.5.1), so we pin to the specific merge commit on main. The old math.h sed workaround is removed (fixed upstream since v0.3.0).

Review & Testing Checklist for Human

  • Build the Docker image and verify pg_textsearch loads (make test). This has not been tested — we're jumping from v0.2.0 to post-v0.5.1, which is a major version leap.
  • Existing BM25 indexes must be recreated after this upgrade. v0.4.0 introduced an incompatible segment format (v3). Confirm there is a plan to REINDEX or drop/recreate all BM25 indexes in any running environments.
  • Verify the commit hash ae1c221 resolves correctly. Consider pinning to the full 40-character SHA for safety against future collisions.
  • Docker build time: The clone changed from --depth 1 (shallow, fast) to a full clone (entire repo history). Consider adding --depth N or --single-branch to keep build times reasonable.
  • Monitor for a tagged release from pg_textsearch that includes the fix, then switch back to a proper version tag.

Notes

Upgrades pg_textsearch to include the ResourceOwnerEnlarge crash fix
from PR #248 (issue #247). The crash occurs when a BM25 index scan
runs inside a transaction that is rolled back.

Changes:
- Pin pg_textsearch to commit ae1c221 on main (no tagged release
  includes the fix yet; latest release is v0.5.1)
- Remove the math.h sed workaround (fixed upstream in v0.3.0)
- Clone full repo instead of shallow tag clone (needed for commit checkout)
@devin-ai-integration
Copy link

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@pyramation pyramation merged commit d2e90d4 into main Mar 4, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant