chore: upgrade js-yaml 3.x → 4.x and csv-parser 2.x → 3.x in csv-to-pg#779
Merged
pyramation merged 1 commit intomainfrom Mar 4, 2026
Merged
chore: upgrade js-yaml 3.x → 4.x and csv-parser 2.x → 3.x in csv-to-pg#779pyramation merged 1 commit intomainfrom
pyramation merged 1 commit intomainfrom
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps two major dependencies in the
csv-to-pgpackage:js-yaml^3.14.0(resolved 3.14.2)^4.1.0(resolved 4.1.1)safeLoad()→load(), unsafe types removed from default schemacsv-parser^2.3.3(resolved 2.3.5)^3.2.0(resolved 3.2.0)No source code changes were needed. The codebase already uses
import { load as parseYAML } from 'js-yaml'(the v4 API name), and csv-parser is used via the standardcreateReadStream().pipe(csv(opts))streaming pattern which is unchanged in v3.The csv-parser upgrade also cleans up transitive deps — it no longer pulls in
minimistorthrough2@3.0.2.Review & Testing Checklist for Human
load()was the unsafe variant (allowed!!js/function,!!js/regexp, etc). In v4,load()is the safe variant (equivalent to oldsafeLoad()). If any YAML config files consumed bycsv-to-pg'sreadConfig()use custom JS types, they will now throw. Verify your YAML configs only use standard YAML types.@types/nodedrift: The lockfile shows several transitive resolutions shifting from@types/node@22.19.11to@types/node@25.3.3(ints-node,grafserv,postgraphileresolution strings). This appears to be a pnpm lockfile artifact from regeneration, not an intentional change. Verify these don't introduce unwanted Node 25 types into packages that should target Node 22.csv-to-pgtests:cd packages/csv-to-pg && pnpm test— CI will cover this, but worth a manual check since both upgrades are major versions with no source code changes to validate compatibility.Notes
pnpm buildRequested by: @pyramation
Link to Devin Session