chore: safe dependency upgrades (@types/node, @types/supertest, @types/shelljs, @types/multer, multer, glob)#778
Merged
pyramation merged 1 commit intomainfrom Mar 4, 2026
Conversation
…s/shelljs, @types/multer, multer, glob)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades low-risk dev-only type packages and two minor runtime dependencies across the monorepo, aligning
@types/nodeto the team's Node 22 target.@types/node^18.19.69/^20.12.7/^20.19.27/^22.19.1^22.19.11@types/supertest^6.0.2/^6.0.3^7.2.0graphql/server-test,jobs/knative-job-service@types/shelljs^0.8.16^0.10.0packages/cli,pgpm/cli@types/multer^1.4.12^2.0.0graphql/servermulter^2.0.1^2.1.0graphql/serverglob^13.0.0^13.0.6packages/clipnpm buildpasses locally. The lockfile also cleaned up some transitive deps (multer@2.1.0droppedmkdirp@0.5.6,object-assign,xtend;undici-typesconsolidated from 3 versions to 2).Review & Testing Checklist for Human
uploads/s3-utils:@types/nodejumped from^18.xto^22.x— largest type leap in this PR. Verify S3 upload code still compiles cleanly and Node stream/buffer types haven't shifted in a way that causes subtle issues at runtimegraphql/servermulter usage:@types/multeris a major bump (1.x → 2.x). Verify thatMulter.Filetype, middleware signatures, and file upload handling still match expectations. The runtimemulterbump is only minor (2.0 → 2.1), but the type change could surface new strictnesspackages/cli,pgpm/cli):@types/shelljsbump to 0.10.0 — verifyshelljscommand usage (e.g.,shell.exec,shell.cd) still has correct typesgraphql/server-testandjobs/knative-job-serviceto ensure@types/supertest7.x doesn't break test type inferenceRecommended test plan: Run the full test suite (
pnpm test) to catch any type-level issues that may not surface during build. Spot-check file upload flows in local dev to ensuremulterbehavior is unchanged.Notes
pnpm buildRequested by: @pyramation
Link to Devin Session