Conversation
Experimenting with if we need these. Signed-off-by: Stefan VanBuren <svanburen@buf.build>
This should all be through `uv` now. Signed-off-by: Stefan VanBuren <svanburen@buf.build>
There was a problem hiding this comment.
Thanks @stefanvanburen - I think they're technically not needed but then python becomes whatever happens to be on the github runner at the time, which can be different as the runner image gets updated even within the same label.
For a simple source-only wheel, it may be a bit pedantic but I tend to like having explicit setup- actions for all dependencies to still ensure tracking of versions used.
As an aside, I just noticed that GitHub's attestations don't display anything about the runner
https://github.com/connectrpc/connect-python/attestations/17478928
Not sure if it's a display or recording issue, but it seems the workflow is easier to verify for these too.
Doesn't the python version just end up getting determined by I hadn't thought about the attestations bit; I don't mind leaving these as-is if they end up being useful in that output down the road. |
|
Ah you're right - I had the impression setup-python picks the minimum supported version like setup-go does, but it seems to not be true. I agree then that uv will have the same behavior, and in practice we are always getting 3.14 here implicitly. Now that we're using renovate, if we hardcoded a value like 3.14 it would automatically get updated, giving a more static view, but don't feel bad about just going with the current state then. |
Experimenting with if we need these.