fix(#3360): add missing "go version" group to Renovate config#3361
fix(#3360): add missing "go version" group to Renovate config#3361fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The org-level Renovate config excludes Go-related packages (golang, go-toolset Docker images and the go directive in go.mod) from the "docker images" and "go modules" groups, expecting them to be handled by a "go version" group — but that group rule was never defined. This caused Go version bump PRs to only update .tool-versions, leaving Dockerfile, Dockerfile.dist, and all go.mod files pinned to the old version. The review agent would flag the mismatch and the PRs would be autoclosed without merging. Add a packageRule in the repo-level renovate.json that groups all Go version dependencies (go, golang, docker.io/library/golang, registry.access.redhat.com/ubi9/go-toolset) under the "go version" groupName. This ensures Renovate updates all 7 files atomically in a single PR. Closes #3360
|
🤖 Finished Review · ✅ Success · Started 8:53 PM UTC · Completed 9:00 PM UTC |
|
Looks good to me. FindingsLow
Labels: PR modifies Renovate dependency management configuration for Go version grouping |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| "github>conforma/.github//config/renovate/renovate.json" | ||
| ], | ||
| "packageRules": [ | ||
| { |
There was a problem hiding this comment.
[low] logic-error
The org-level Renovate config excludes golang/go from the 'docker images' group (via matchPackageNames: ["!golang/go"]), but the new repo-level 'go version' group does not include golang/go in its matchDepNames. If Renovate ever identifies a dependency with that name, it would be excluded from 'docker images' but not captured by 'go version', leaving it ungrouped. No file in this repo currently uses golang/go as a dependency name, so this is a theoretical gap rather than an active defect.
Suggested fix: Consider adding "golang/go" to the matchDepNames array for completeness and symmetry with the org-level exclusion list.
fullsend-ai-review
Bot
added
ready-for-merge
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The org-level Renovate config excludes Go-related packages (golang, go-toolset Docker images and the go directive in go.mod) from the "docker images" and "go modules" groups, expecting them to be handled by a "go version" group — but that group rule was never defined.
This caused Go version bump PRs to only update .tool-versions, leaving Dockerfile, Dockerfile.dist, and all go.mod files pinned to the old version. The review agent would flag the mismatch and the PRs would be autoclosed without merging.
Add a packageRule in the repo-level renovate.json that groups all Go version dependencies (go, golang, docker.io/library/golang, registry.access.redhat.com/ubi9/go-toolset) under the "go version" groupName. This ensures Renovate updates all 7 files atomically in a single PR.
Closes #3360
Post-script verification
agent/3360-renovate-go-version-group)76afa950a33babbf6b18ff2d9468c21d74ffe34e..HEAD)