fix: warning - ref.measureLayout must be called with a node handle.#544
Open
Krishna2323 wants to merge 1 commit intocomputerjazz:mainfrom
Open
fix: warning - ref.measureLayout must be called with a node handle.#544Krishna2323 wants to merge 1 commit intocomputerjazz:mainfrom
Krishna2323 wants to merge 1 commit intocomputerjazz:mainfrom
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
50 tasks
6 tasks
|
@computerjazz Hey mate, can you merge it? |
|
@computerjazz would be great if you could merge this, thanks. |
|
@computerjazz could you merge it? |
|
@computerjazz can this be merged :)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When a new list item is added in
NestableDraggableFlatListwe get the warningWarning: ref.measureLayout must be called with a node handle or a ref to a native component.This happens because we are using
findNodeHandleand this PR in react-native now allows measureLayout to be passed a ref and throw the warning if node is passed.react-native-draggable-flatlist/src/components/NestableDraggableFlatList.tsx
Line 51 in ebfddc4
react-native-draggable-flatlist/src/components/NestableDraggableFlatList.tsx
Line 60 in ebfddc4
Demo
340080842-d9cafd74-479f-4ec5-abfa-7cc51a51138e.mp4