Add Support for Custom Alert Titles#430
Open
rdestefa wants to merge 1 commit intocommonmark:mainfrom
Open
Conversation
3ba29d4 to
84f6dc9
Compare
84f6dc9 to
a4bc9d1
Compare
a4bc9d1 to
d649322
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made an initial attempt at implementing support for custom titles in alerts (#429). I kept running into issues when trying to enhance the post processor because there's no access to an inline parser and it was susceptible to edge cases where inline nodes would overlap between the title and the body. For example:
The
*s would create anEmphasisnode which made splitting out the title text difficult, when in reality those lines should be parsed separately. I decided to try and make a customAlertBlockParserinstead to have more control.I'm not sure if this is the right approach, but it seemed to work well for me. A few things I noticed, though, with this new parser:
> [!NOTE] Title Lazy bodyBlockQuote > Paragraph, and the paragraph allows lazy continuation.