refactor(check): remove unnecessary list construction#1455
Closed
bearomorphism wants to merge 1 commit intocommitizen-tools:masterfrom
Closed
refactor(check): remove unnecessary list construction#1455bearomorphism wants to merge 1 commit intocommitizen-tools:masterfrom
bearomorphism wants to merge 1 commit intocommitizen-tools:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1455 +/- ##
==========================================
+ Coverage 97.33% 97.62% +0.28%
==========================================
Files 42 57 +15
Lines 2104 2650 +546
==========================================
+ Hits 2048 2587 +539
- Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
reviewed
May 25, 2025
| self._valid_command_argument() | ||
|
|
||
| self.config: BaseConfig = config | ||
| self.config = config |
Member
There was a problem hiding this comment.
Is there any reason we remove it?
| if not line.startswith("#"): | ||
| lines.append(line) | ||
| return "\n".join(lines) | ||
| msg_lines = msg.split("\n") |
Member
There was a problem hiding this comment.
Not sure whether we want to do this. Look like we'll loop through lines twice and the logic looks more complicated
Collaborator
Author
|
I'm closing this one. This does not make it more readable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsExpected Behavior
Steps to Test This Pull Request
Additional Context