build(termcolor): remove termcolor <3 restriction#1450
build(termcolor): remove termcolor <3 restriction#1450Lee-W merged 2 commits intocommitizen-tools:refactorsfrom
Conversation
d5a08bf to
996650e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1450 +/- ##
=============================================
- Coverage 97.78% 97.78% -0.01%
=============================================
Files 57 57
Lines 2620 2617 -3
=============================================
- Hits 2562 2559 -3
Misses 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm now using commitizen with termcolor 3.1.0 and it looks good so far. |
|
@bearomorphism I tried to rebased it on the latest |
|
It happens sometime. I'll try to trigger the checks again. |
|
I actaully triggered but it still failed 🤔 |
1245f4d to
b0d8901
Compare
|
sounds weird. |
|
https://pypi.org/project/termcolor/ termcolor says it supports python 3.9? |
|
looks like so 🤔 |
|
let me try it with python 3.9 on my machine |
b0d8901 to
6ccf12c
Compare
|
IIRC |
|
I suspect some dependency broke the test when using termcolor 3 |
|
|
|
|
fixed |
0623dd5 to
4b99435
Compare
pyproject.toml
Outdated
| # Use the Python 3.11 and 3.12 compatible API: https://github.com/python/importlib_metadata#compatibility | ||
| "importlib_metadata (>=8.0.0,<9) ; python_version < '3.10'", | ||
|
|
||
| "importlib-metadata >=8.0.0,<8.7.0 ; python_version < '3.10'", # importlib-metadata@8.7.0 + python3.9 breaks our unit test |
There was a problem hiding this comment.
We probably could use != for 3.9 and still use >=8.0.0,<9.0.0 for others
e24e833 to
7af56c6
Compare
7af56c6 to
b16d901
Compare
Closes #1420
Description
Checklist
Additional Context
https://github.com/termcolor/termcolor/releases