fix(bump): don't fail if an invalid version tag is present (fix #1410)#1418
Merged
noirbizarre merged 1 commit intocommitizen-tools:masterfrom May 16, 2025
Merged
Conversation
c18076d to
89d5605
Compare
89d5605 to
82f013c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
+ Coverage 97.33% 97.57% +0.23%
==========================================
Files 42 57 +15
Lines 2104 2682 +578
==========================================
+ Hits 2048 2617 +569
- Misses 56 65 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a regression introduced in the 4.4.0 by #1297:
bumpcommand is failing when an invalid tag is present and not listed inignored_tagswhile it was just warning about before.This PR restores this behavior (bump will work if an invalid tag is present, but a warning will be emitted).
The error/warning message is now the same whatever the place it is triggered.
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsmaintainedrestoredDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctly (N/A)Expected Behavior
Cf. #1410
Steps to Test This Pull Request
Cf. #1410
Additional Context
Supersedes and closes #1410