Merged
Conversation
…ngelog to the right place
Member
|
Hey, sorry for the late review. I just came back and tried to rebase from the latest main. |
…struction from args and config
…d modify the path linter and test parameter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1391 +/- ##
==========================================
+ Coverage 97.33% 97.55% +0.21%
==========================================
Files 42 57 +15
Lines 2104 2658 +554
==========================================
+ Hits 2048 2593 +545
- Misses 56 65 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
approved these changes
May 6, 2025
Member
Lee-W
left a comment
There was a problem hiding this comment.
I'm good with this PR. Thanks @Yusin0903 . But will leave it open for a few days so that others can check as well
woile
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the construction of the changelog file name in changelog.py to ensure type safety and correct path handling. It also adds proper error handling for missing or invalid changelog file names.
Checklist
poetry alllocally to ensure this change passes linter check and testExpected behavior
The changelog command should now correctly resolve the changelog file path, regardless of whether the config path is set, and should raise a clear error if the file name is missing or invalid.
Steps to Test This Pull Request
poetry alland ensure all checks pass.--file-nameargument.Additional context
Sorry, I don' t know why my last branch have hide word problem. So I open lots of PR and close them .
By the way, I saw the github action warning
This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see https://github.com/actions/runner-images/issues/11101Show more