ci(github-actions): add check-commit task#1357
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
==========================================
+ Coverage 97.33% 97.55% +0.22%
==========================================
Files 42 55 +13
Lines 2104 2622 +518
==========================================
+ Hits 2048 2558 +510
- Misses 56 64 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@noirbizarre could you please take a quick look when you have some bandwidth 🙂 This would prevent us from merging PR with wrong commit format accidentally |
|
Note that I thought it was already done by commitizen pre-commit hook:https://github.com/commitizen-tools/commitizen/blob/master/.pre-commit-config.yaml#L50-L56 |
It actually is, but it's also quite common for a new contributor to miss this step (and us to accidentally merge it) so better to add an additional safe guard I think 🤔 |
Description
In #1354, commit check was missed. This PR is to add it back
Checklist
poetry alllocally to ensure this change passes linter check and testExpected behavior
invalid commit should raise an error when running
poetry commit-checkSteps to Test This Pull Request
poetry commit-checkAdditional context