Open
Conversation
benjaminstrasser
force-pushed
the
feat/project-slug
branch
from
d83570b to
1fb9150
Compare
benjaminstrasser
force-pushed
the
shared-folder
branch
from
bd18a47 to
e6618a8
Compare
sjaghori
reviewed
Jul 24, 2024
Collaborator
sjaghori
left a comment
sjaghori
left a comment
There was a problem hiding this comment.
we need eslint rules ('import/no-restricted-paths' package e.g.) to keep things separat:
TODO's:
- prevents imports from src/* into services/*
- prevents imports from src/* into shared/*
- prevents imports from services/* into shared/*
vite.config.ts
Outdated
| include: ['src/**/*.{test,spec}.{js,ts}', 'services/**/*.{test,spec}.{js,ts}'] | ||
| }, | ||
| server: { port: 3000, fs: { allow: ['services/src/util/slug'] } }, // Add shared workspace and move slug to shared | ||
| server: { port: 3000, fs: { allow: ['shared/src'] } }, |
Collaborator
There was a problem hiding this comment.
a general question, do we want to have a src folder inside shared workspace? Just saying that we don't have to.
Contributor
There was a problem hiding this comment.
I think it we could get rid of the src folder.
benjaminstrasser
force-pushed
the
feat/project-slug
branch
2 times, most recently
from
0510a72 to
e2b0434
Compare
sjaghori
force-pushed
the
feat/project-slug
branch
from
23512be to
6a360f4
Compare
benjaminstrasser
force-pushed
the
shared-folder
branch
3 times, most recently
from
e6618a8 to
a3ce1f4
Compare
benjaminstrasser
force-pushed
the
shared-folder
branch
from
a3ce1f4 to
9a978f9
Compare
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
…s not supported by pnpm, fixes ci, updates pnpm, vitest & vite
sjaghori
force-pushed
the
shared-folder
branch
from
9087cc5 to
27f6435
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.