Conversation
slaveeks
approved these changes
Apr 4, 2026
neSpecc
approved these changes
Apr 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR improves breadcrumb rendering for deeply nested documentation pages by collapsing long trails into a compact form to keep the header readable.
Changes:
- Add backend breadcrumb generation (
first ancestor → ellipsis → current) and pass it into the page template. - Update the page header Twig template to render breadcrumbs from a provided
breadcrumbItemslist. - Adjust page header CSS flex/overflow rules to prevent breadcrumb overflow and ensure truncation behaves well.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/styles/components/page.pcss | Adds flex/overflow/ellipsis styling to keep long breadcrumb text from breaking the header layout. |
| src/backend/views/pages/page.twig | Switches breadcrumb rendering to iterate over breadcrumbItems (supports ellipsis + current page styling). |
| src/backend/utils/breadcrumbs.ts | Introduces breadcrumb-building helper and collapsing logic. |
| src/backend/routes/pages.ts | Uses buildPageBreadcrumbs and passes breadcrumbItems to the page view. |
| src/backend/routes/aliases.ts | Uses buildPageBreadcrumbs for alias-served pages and passes breadcrumbItems to the page view. |
| src/backend/models/page.ts | Adds getAncestorChain() to retrieve ancestors for breadcrumb construction. |
| src/backend/build-static.ts | Passes breadcrumbItems during static page rendering. |
| package.json | Bumps package version to 2.3.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before
After