feat: add command to create a test user for automated testing by OliverTrautvetter · Pull Request #329 · codesphere-cloud/oms

OliverTrautvetter · 2026-04-16T11:39:37Z

Copilot

Pull request overview

Adds a new OMS CLI capability to create a Codesphere “test user” (password + API token) directly in PostgreSQL for automated smoke testing, and wires it into docs and (optionally) the GCP bootstrap flow.

Changes:

Introduce internal/testuser package to generate credentials, hash them with Codesphere-compatible scheme, insert required DB records, and persist results as JSON.
Add oms create test-user command group/command and corresponding CLI docs.
Adjust GCP bootstrap package download invocation and bump/add Go dependencies (sqlmock, lib/pq).

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`internal/testuser/testuser.go`	Implements test user creation, DB inserts, result logging/persistence
`internal/testuser/hash.go`	Adds hashing helpers for password/API token
`internal/testuser/hash_test.go`	Unit tests for hashing
`internal/testuser/testuser_test.go`	Unit tests for token generation, file writing, and DB logic via sqlmock
`internal/testuser/testuser_suite_test.go`	Ginkgo suite bootstrap for new package
`cli/cmd/create.go`	Adds `oms create` command group
`cli/cmd/create_test_user.go`	Adds `oms create test-user` cobra command
`cli/cmd/root.go`	Registers the new `create` command group
`cli/cmd/bootstrap_gcp.go`	Adds optional `--create-test-user` behavior post-bootstrap
`internal/bootstrap/gcp/gcp.go`	Changes jumpbox download command to include OMS portal env vars
`internal/bootstrap/gcp/gcp_test.go`	Updates expected download command strings in tests
`docs/oms_create.md` / `docs/oms_create_test-user.md`	New CLI documentation pages
`docs/oms.md` / `docs/README.md`	Adds `oms create` to command index
`docs/oms_beta_bootstrap-gcp.md`	Documents `--create-test-user` flag
`go.mod` / `go.sum`	Adds `go-sqlmock`, bumps `github.com/lib/pq`
`NOTICE` / `internal/tmpl/NOTICE`	Updates NOTICE entries for `github.com/lib/pq` version bump

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

joka134

First comments, still debugging the command a little more tomorrow

Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>

joka134

Nice, much cleaner. Still some comments going into a similar direction

…ferences

Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>

…d/oms into create_test_user

joka134

some small things + the one thing we discussed

joka134 · 2026-04-23T08:20:01Z

+	_ = session.Setenv("OMS_PORTAL_API", os.Getenv("OMS_PORTAL_API"))
 	_ = agent.RequestAgentForwarding(session) // Best effort, ignore errors

+	var stderrBuf bytes.Buffer


Suggested change

var stderrBuf bytes.Buffer

var stderrBuf bytes.Buffer

session.Stderr = &stderrBuf

and drop the else statement

joka134 · 2026-04-23T08:31:23Z

 	defer util.IgnoreError(session.Close)

 	_ = session.Setenv("OMS_PORTAL_API_KEY", os.Getenv("OMS_PORTAL_API_KEY"))
+	_ = session.Setenv("OMS_PORTAL_API", os.Getenv("OMS_PORTAL_API"))


Why is needed for test user creation?

joka134 · 2026-04-23T11:20:14Z

+}
+
+// newWithDB creates a TestUserCreator with an already-opened DB.
+func newWithDB(opts CreateTestUserOpts, db *sql.DB) *TestUserCreator {


Do we need this? In the tests you can also just use &TestUserCreator{opts: opts, db: db}, right

joka134 · 2026-04-23T15:02:45Z

+
+// HashPassword hashes a password using Codesphere's double-SHA256 scheme with salts.
+// The salts are read from environment variables OMS_CS_SALT_1 and OMS_CS_SALT_2.
+func HashPassword(password string) (string, error) {


Maybe I came to a new conclusion to just keep out the salts of oms and create a password hash manually, that is provided via env. That means the test user always gets the same password, which is fine as signup is usually open for test instances. And now one will be forced to copy/paste salts to local environments 😆
The password (+ hash for local development) will be stored in 1password

OliverTrautvetter requested a review from Copilot April 17, 2026 09:11

Copilot started reviewing on behalf of OliverTrautvetter April 17, 2026 09:12 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

OliverTrautvetter requested a review from Copilot April 17, 2026 11:08

Copilot started reviewing on behalf of OliverTrautvetter April 17, 2026 11:09 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Comment thread internal/testuser/testuser.go Outdated

Comment thread internal/installer/node/node.go Outdated

Comment thread cli/cmd/bootstrap_gcp.go Outdated

Comment thread cli/cmd/create_test_user.go Outdated

Comment thread internal/testuser/hash.go Outdated

OliverTrautvetter requested a review from joka134 April 17, 2026 13:57

OliverTrautvetter marked this pull request as ready for review April 17, 2026 14:02

feat: add command to create a test user for automated testing

8b27054

OliverTrautvetter force-pushed the create_test_user branch from 30b3192 to 8b27054 Compare April 20, 2026 14:40

OliverTrautvetter added 2 commits April 20, 2026 16:44

Merge branch 'main' into create_test_user

71a38c5

ref: fix linter

99f814c

joka134 requested changes Apr 20, 2026

View reviewed changes

Comment thread cli/cmd/bootstrap_gcp.go Outdated

Comment thread internal/testuser/testuser.go

Comment thread internal/testuser/testuser.go Outdated

Comment thread internal/testuser/testuser.go

Comment thread internal/testuser/testuser.go

Comment thread internal/testuser/hash.go Outdated

OliverTrautvetter added 4 commits April 21, 2026 15:42

ref: enhance test user creation logic and add password generation tests

2e0105b

Merge branch 'main' into create_test_user

68e1313

Merge branch 'main' into create_test_user

e6a7d70

chore(docs): Auto-update docs and licenses

e26e487

Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>

OliverTrautvetter requested a review from joka134 April 21, 2026 14:17

joka134 requested changes Apr 21, 2026

View reviewed changes

OliverTrautvetter added 5 commits April 22, 2026 14:45

ref: streamline test user creation and update environment variable re…

11b5982

…ferences

Merge branch 'main' into create_test_user

b26d2c0

chore(docs): Auto-update docs and licenses

dc580ca

Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>

ref: enhance error handling in RunCommand for quiet mode

87808bd

Merge branch 'create_test_user' of https://github.com/codesphere-clou…

d99fd2f

…d/oms into create_test_user

OliverTrautvetter requested a review from joka134 April 22, 2026 13:27

joka134 requested changes Apr 23, 2026

View reviewed changes

	var stderrBuf bytes.Buffer
	var stderrBuf bytes.Buffer
	session.Stderr = &stderrBuf

Conversation

OliverTrautvetter commented Apr 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joka134 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joka134 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joka134 left a comment

Choose a reason for hiding this comment

Uh oh!

joka134 Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

joka134 Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

joka134 Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

joka134 Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants