feat: make keyring opt-in and store token at login#835
Merged
Conversation
EhabY
force-pushed
the
feat/keyring-opt-in
branch
3 times, most recently
from
9b16970 to
f734007
Compare
- Default `coder.useKeyring` to false (opt-in) due to shared logout side effects between CLI and IDE - Update setting description to document sync behavior and version requirements - Store token to OS keyring at login time so the CLI picks it up immediately - Show cancellable progress notification for all CLI keyring invocations during login - Migrate CliCredentialManager public API to options bag pattern with signal and keyringOnly support
EhabY
force-pushed
the
feat/keyring-opt-in
branch
from
f734007 to
30794d9
Compare
DanielleMaywood
approved these changes
Mar 16, 2026
Collaborator
DanielleMaywood
left a comment
DanielleMaywood
left a comment
There was a problem hiding this comment.
Works on my machine ™️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coder.useKeyringto false (opt-in) due to shared logout side effects between CLI and IDECliCredentialManagerpublic API to options bag pattern with signal and keyringOnly supportCloses #836