🤖 refactor: remove workflow-smoke built-in skill#3615
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82c3a4ec46
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
workflows-kd21
branch
from
82c3a4e to
0f5915b
Compare
|
@codex review Please take another look. I addressed the CLI smoke-test feedback by switching the docs example back to cheap local workflow files and avoiding a user-copyable deep-research invocation. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f5915b224
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
workflows-kd21
branch
from
0f5915b to
8708953
Compare
|
@codex review Please take another look. I addressed the built-in skill shadowing feedback by isolating skill roots for the deep-research built-in resolution tests. |
ThomasK33
force-pushed
the
workflows-kd21
branch
from
8708953 to
e137d8c
Compare
|
@codex review Please take another look after the rebase onto latest main. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
1 participant
Summary
Remove the hidden
workflow-smokebuilt-in skill now thatdeep-researchprovides a real built-in skill-packaged workflow for exercisingskill://resolution paths in tests.Implementation
workflow-smokebuilt-in skill markdown and workflow script.skill://deep-research/workflow.jswith isolated test skill roots so developer-global skills cannot shadow the built-in package.Validation
bun test src/node/services/agentSkills/agentSkillsService.test.ts src/node/services/workflows/workflowScriptResolver.test.ts src/node/services/tools/workflow_run.test.tsbun test src/node/services/mock/mockAiStreamPlayer.test.tsbun test src/node/services/mock/mockAiStreamPlayer.test.ts -t 'does not let stale stream-end cleanup delete a replacement stream partial'MUX_ESLINT_CONCURRENCY=1 make static-checkgit diff --checkbun test --max-concurrency=1 src/node/services/workflows/WorkflowRunner.test.ts src/node/orpc/router.test.ts src/browser/components/WorkspaceHeartbeatModal/WorkspaceHeartbeatModal.test.tsx src/browser/features/Messages/InlineSkillMarkdown.test.tsx src/browser/hooks/useChatTranscriptFullWidth.test.tsx src/browser/utils/commands/sources.test.tsRisks
Low. This removes a hidden fixture-only skill and leaves packaged built-in workflow coverage on the existing deep-research skill without exposing it as a cheap CLI smoke-test example.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:542744{MUX_COSTS_USD:-unknown}